Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(PR, commit): Restrict commit message and PR title to CC format #982

Merged
merged 6 commits into from
Jan 31, 2024
Merged

build(PR, commit): Restrict commit message and PR title to CC format #982

merged 6 commits into from
Jan 31, 2024

Conversation

VadymBezpalko
Copy link
Contributor

@VadymBezpalko VadymBezpalko commented Jan 24, 2024 •
edited
Loading

Resolves: #981

Description

  • Adding CommitLint and husky git hook for commit messages to stick to conventional commits format.
  • Adding GH Action to ensure that PR is named correctly (in CC format)

Storybook

https://feature-981--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@VadymBezpalko VadymBezpalko added the dependencies Pull requests that update a dependency file label Jan 24, 2024
@VadymBezpalko VadymBezpalko self-assigned this Jan 24, 2024
@VadymBezpalko VadymBezpalko changed the title build(commit): adding commitlint to restrict commit messages #000: Testing PR checker Jan 30, 2024
@VadymBezpalko VadymBezpalko changed the title #000: Testing PR checker Testing PR checker Jan 30, 2024
@VadymBezpalko VadymBezpalko changed the title Testing PR checker #000: Testing PR checker Jan 30, 2024
@VadymBezpalko VadymBezpalko changed the title #000: Testing PR checker build(PR, commit): Restrict commit message and PR title to CC format Jan 30, 2024
@VadymBezpalko VadymBezpalko merged commit e1eb541 into main Jan 31, 2024
5 checks passed
@VadymBezpalko VadymBezpalko deleted the feature/981 branch January 31, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinsawicki marcinsawicki marcinsawicki approved these changes

@sgraczyk sgraczyk Awaiting requested review from sgraczyk

Assignees

@VadymBezpalko VadymBezpalko

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DevOps] - Add a commitlint tool to improve development experience
2 participants
@VadymBezpalko @marcinsawicki