Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light/Dark theme visual tests in Chromatic #978

Merged
merged 9 commits into from
Jan 23, 2024

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Jan 22, 2024

Description

Changed the themes addon + added background addon, both used in the Chromatic visual tests.
Enabled light/dark mode visual tests for every component.

Storybook

https://feature-chromatic-test-dark-mode--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki self-assigned this Jan 23, 2024
@marcinsawicki marcinsawicki added the documentation Documentation of any kind label Jan 23, 2024
@marcinsawicki marcinsawicki added this to the Maintenance milestone Jan 23, 2024
@marcinsawicki marcinsawicki changed the title chromatic dm test Light/Dark theme visual tests in Chromatic Jan 23, 2024
@marcinsawicki marcinsawicki marked this pull request as ready for review January 23, 2024 08:57
@marcinsawicki marcinsawicki merged commit 92b4aae into main Jan 23, 2024
4 checks passed
@marcinsawicki marcinsawicki deleted the feature/chromatic-test-dark-mode branch January 23, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation of any kind
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants