Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Avatar): handle emojis as text input #967

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix(Avatar): handle emojis as text input #967

merged 2 commits into from
Jan 12, 2024

Conversation

michalszpyruk
Copy link
Contributor

@michalszpyruk michalszpyruk commented Jan 11, 2024

Resolves: #963

Description

Small fix to getInitials function as currently charAt(0) throws undefined for emojis.

Storybook

https://feature-963--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@michalszpyruk michalszpyruk added the bug Something isn't working label Jan 11, 2024
@michalszpyruk michalszpyruk requested a review from a team January 11, 2024 16:26
@michalszpyruk michalszpyruk marked this pull request as ready for review January 11, 2024 16:26
@VadymBezpalko VadymBezpalko added this to the v1.0 milestone Jan 12, 2024
@VadymBezpalko VadymBezpalko merged commit 1e62f3d into main Jan 12, 2024
5 checks passed
@VadymBezpalko VadymBezpalko deleted the feature/963 branch January 12, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Avatar - issue with emoji names
3 participants