Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Alert): Close button placement for large container #958

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fix(Alert): Close button placement for large container #958

merged 2 commits into from
Jan 9, 2024

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Jan 9, 2024 •
edited
Loading

Resolves: #942

Description

Change close button placement for the large container.

Storybook

https://feature-942--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the bug Something isn't working label Jan 9, 2024
@marcinsawicki marcinsawicki added this to the v1.0 milestone Jan 9, 2024
@marcinsawicki marcinsawicki self-assigned this Jan 9, 2024
@marcinsawicki marcinsawicki marked this pull request as ready for review January 9, 2024 09:09
vladko-uxds
vladko-uxds approved these changes Jan 9, 2024
View reviewed changes
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcinsawicki marcinsawicki merged commit 3d6e492 into main Jan 9, 2024
4 checks passed
@marcinsawicki marcinsawicki deleted the feature/942 branch January 9, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladko-uxds vladko-uxds vladko-uxds approved these changes

@VadymBezpalko VadymBezpalko VadymBezpalko approved these changes

Assignees

@marcinsawicki marcinsawicki

Labels
bug Something isn't working
Projects
LiveChat Design System
Archived in project
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

[Alert] - Position of dismissal button
3 participants
@marcinsawicki @VadymBezpalko @vladko-uxds