Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Icons): Add missing ticket priority icons #1005

Merged
merged 2 commits into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/icons/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ import { Icon } from '@livechat/design-system-react-components';

3. To add a new icon, you need to add a prepared SVG file to the `./svg` directory. The file name should be in the **snake_case** format with `-filled` addition in the name for filled icon variants.

4. You should execute the `npm run build` command, and our scripts will handle the rest, including adding a new export entry in the <i>package.json</i> file and <i>entryConfig.ts.</i>
5. Commit your changes and create a pull request. ⚠️ Commit message should follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) naming pattern `feat(icons): add new icon`. ⚠️ This is crucial as, post squash merging, Git will use the PR name as the commit message.
4. Then add new prop to `IconsData` in format `<icon-name>: <icon-group-name>;`.

5. You should execute the `npm run build` command, and our scripts will handle the rest, including adding a new export entry in the <i>package.json</i> file and <i>entryConfig.ts.</i>

6. Commit your changes and create a pull request. ⚠️ Commit message should follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) naming pattern `feat(icons): add new icon`. ⚠️ This is crucial as, post squash merging, Git will use the PR name as the commit message.
6. After the pull request is merged, the changes will be published by the Design System team in the next release.
4 changes: 4 additions & 0 deletions packages/icons/entryConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,12 @@ const entryConfig = {
DiscountFilled: './lib/DiscountFilled.tsx',
DismissChat: './lib/DismissChat.tsx',
DismissChatFilled: './lib/DismissChatFilled.tsx',
DoubleArrowDown: './lib/DoubleArrowDown.tsx',
DoubleArrowLeft: './lib/DoubleArrowLeft.tsx',
DoubleArrowLeftFilled: './lib/DoubleArrowLeftFilled.tsx',
DoubleArrowRight: './lib/DoubleArrowRight.tsx',
DoubleArrowRightFilled: './lib/DoubleArrowRightFilled.tsx',
DoubleArrowUp: './lib/DoubleArrowUp.tsx',
DragIndicator: './lib/DragIndicator.tsx',
DragIndicatorFilled: './lib/DragIndicatorFilled.tsx',
DropDown: './lib/DropDown.tsx',
Expand Down Expand Up @@ -326,6 +328,8 @@ const entryConfig = {
PlayCircleFilled: './lib/PlayCircleFilled.tsx',
PlayerRecord: './lib/PlayerRecord.tsx',
PlayerRecordFilled: './lib/PlayerRecordFilled.tsx',
Point: './lib/Point.tsx',
PointFilled: './lib/PointFilled.tsx',
Position: './lib/Position.tsx',
PositionFilled: './lib/PositionFilled.tsx',
PowerSettings: './lib/PowerSettings.tsx',
Expand Down
20 changes: 20 additions & 0 deletions packages/icons/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -837,6 +837,11 @@
"require": "./dist/DismissChatFilled.cjs.js",
"types": "./dist/DismissChatFilled.d.ts"
},
"./DoubleArrowDown": {
"import": "./dist/DoubleArrowDown.es.js",
"require": "./dist/DoubleArrowDown.cjs.js",
"types": "./dist/DoubleArrowDown.d.ts"
},
"./DoubleArrowLeft": {
"import": "./dist/DoubleArrowLeft.es.js",
"require": "./dist/DoubleArrowLeft.cjs.js",
Expand All @@ -857,6 +862,11 @@
"require": "./dist/DoubleArrowRightFilled.cjs.js",
"types": "./dist/DoubleArrowRightFilled.d.ts"
},
"./DoubleArrowUp": {
"import": "./dist/DoubleArrowUp.es.js",
"require": "./dist/DoubleArrowUp.cjs.js",
"types": "./dist/DoubleArrowUp.d.ts"
},
"./DragIndicator": {
"import": "./dist/DragIndicator.es.js",
"require": "./dist/DragIndicator.cjs.js",
Expand Down Expand Up @@ -1667,6 +1677,16 @@
"require": "./dist/PlayerRecordFilled.cjs.js",
"types": "./dist/PlayerRecordFilled.d.ts"
},
"./Point": {
"import": "./dist/Point.es.js",
"require": "./dist/Point.cjs.js",
"types": "./dist/Point.d.ts"
},
"./PointFilled": {
"import": "./dist/PointFilled.es.js",
"require": "./dist/PointFilled.cjs.js",
"types": "./dist/PointFilled.d.ts"
},
"./Position": {
"import": "./dist/Position.es.js",
"require": "./dist/Position.cjs.js",
Expand Down
3 changes: 3 additions & 0 deletions packages/icons/svg/double_arrow_down.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/icons/svg/double_arrow_up.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/icons/svg/point-filled.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/icons/svg/point.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ export const IconsData: Record<IconName, IconGroup> = {
ChevronRight: IconGroup.Arrows,
ChevronUpFilled: IconGroup.Arrows,
ChevronUp: IconGroup.Arrows,
DoubleArrowDown: IconGroup.Arrows,
DoubleArrowLeftFilled: IconGroup.Arrows,
DoubleArrowLeft: IconGroup.Arrows,
DoubleArrowRightFilled: IconGroup.Arrows,
DoubleArrowRight: IconGroup.Arrows,
DoubleArrowUp: IconGroup.Arrows,

//FileType
FiletypeExe: IconGroup.FileType,
Expand Down Expand Up @@ -311,6 +313,8 @@ export const IconsData: Record<IconName, IconGroup> = {
PlayCircle: IconGroup.General,
PlayerRecordFilled: IconGroup.General,
PlayerRecord: IconGroup.General,
Point: IconGroup.General,
PointFilled: IconGroup.General,
PositionFilled: IconGroup.General,
Position: IconGroup.General,
PowerSettingsFilled: IconGroup.General,
Expand Down
Loading