Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): Fixes for typography component usage in Input, TagInput and Textarea #1002

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Feb 13, 2024

Resolves: #{issue-number}

Description

Fix for wrong implemented typography component in the Input, TagInput and Textarea, that causes the unexpected reduction in input size inside the wrapper.
This changes fix that.

Storybook

https://feature-input-typography-fix--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the bug Something isn't working label Feb 13, 2024
@marcinsawicki marcinsawicki added this to the v1.0 milestone Feb 13, 2024
@marcinsawicki marcinsawicki marked this pull request as ready for review February 13, 2024 11:19
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcinsawicki marcinsawicki merged commit ca9632a into main Feb 13, 2024
9 checks passed
@marcinsawicki marcinsawicki deleted the feature/input-typography-fix branch February 13, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants