Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

[feature] Private mode #34

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[feature] Private mode #34

wants to merge 15 commits into from

Conversation

shwarcu
Copy link
Member

@shwarcu shwarcu commented Mar 11, 2022 •
edited
Loading

Description:
Provide API for retrieving and tracking status of private mode switch for the thread.

Todo:

  • Proposal of API
  • Example usage
  • Documentation of the feature - PR to public docs needs to be reviewed in context of this PR
  • Manual testing

End user cases that need to be covered by SDK and tested:

  • opening widget when there are ongoing chats with enabled private mode
  • enabling and disabling private mode in chat
  • enabling and disabling private mode in several ongoing chats

Regression to test before merge:

  • MessageBox widget
  • Details widget

@shwarcu shwarcu mentioned this pull request Mar 14, 2022
Closed
@shwarcu shwarcu marked this pull request as ready for review March 15, 2022 08:37
@shwarcu shwarcu added the enhancement New feature or request label Mar 15, 2022
@shwarcu shwarcu self-assigned this Mar 15, 2022
@shwarcu shwarcu changed the title [WIP] Private mode [feature] Private mode Mar 15, 2022
@shwarcu shwarcu requested review from sgraczyk and walaszczykm March 23, 2022 17:39
walaszczykm
walaszczykm reviewed Mar 24, 2022
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
src/widgets/messagebox/messagebox-widget.ts Outdated Show resolved Hide resolved
@shwarcu shwarcu requested a review from walaszczykm April 7, 2022 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@walaszczykm walaszczykm walaszczykm left review comments

@sgraczyk sgraczyk sgraczyk approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@shwarcu shwarcu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shwarcu @sgraczyk @walaszczykm