Update name attribute for suburb_locality #653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description:
Update the name attribute from 'suburb_4th', 'suburb_3rd', 'suburb_2nd', ' suburb_1st' to 'name', using the new NZ Suburbs and Localities schema.
Notes for Testing:
All test (db+plugin) passed.
Note that there's one test commented out - https://github.com/linz/nz-buildings/blob/master/buildings/tests/gui/test_processes_update_reference_data_admin_bdys.py
I've checked that and make sure the failure was due to the previous found issue not the changes here. This test will be remove once we develop the new method for ref update.
...
Source Code Documentation Tasks:
- [ ] README updated (where applicable)- [ ] CHANGELOG (Unreleased section) updatedwill update in the next PR- [ ] Docstrings / comments included to help explain codeUser Documentation Tasks:
- [ ] Confluence user guide updated (where applicable)Testing Tasks:
- [ ] Linked to main issue for ZenHub board