Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name attribute for suburb_locality #653

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Conversation

YingtingChen
Copy link
Contributor

@YingtingChen YingtingChen commented Jul 24, 2024

Change Description:

Update the name attribute from 'suburb_4th', 'suburb_3rd', 'suburb_2nd', ' suburb_1st' to 'name', using the new NZ Suburbs and Localities schema.

Notes for Testing:

All test (db+plugin) passed.

Note that there's one test commented out - https://github.com/linz/nz-buildings/blob/master/buildings/tests/gui/test_processes_update_reference_data_admin_bdys.py
I've checked that and make sure the failure was due to the previous found issue not the changes here. This test will be remove once we develop the new method for ref update.
...

Source Code Documentation Tasks:

- [ ] README updated (where applicable)
- [ ] CHANGELOG (Unreleased section) updated will update in the next PR
- [ ] Docstrings / comments included to help explain code

User Documentation Tasks:

- [ ] Confluence user guide updated (where applicable)

Testing Tasks:

  • All tests are passing in development environment
  • Reviewers assigned
    - [ ] Linked to main issue for ZenHub board

Copy link
Contributor

@Douglas-K Douglas-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes look good. Code looks fine and the tests passed. Thanks Yingting.

@YingtingChen YingtingChen merged commit 2b37dd9 into master Aug 22, 2024
20 checks passed
@YingtingChen YingtingChen deleted the update_suburb_name branch August 22, 2024 05:36
@Douglas-K Douglas-K removed the request for review from jducnuigeen August 30, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants