Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double click to activate the detail window #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

add-uos
Copy link
Contributor

@add-uos add-uos commented Sep 29, 2024

fix the double click to activate the detail window

Log: fix the double click to activate the detail window
Bug: https://pms.uniontech.com/bug-view-269597.html

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fix the double click to activate the detail window

Log: fix the double click to activate the detail window
Bug: https://pms.uniontech.com/bug-view-269597.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ThumbnailListShare.js文件中,isFaverDoubleClicked变量被声明但未在代码中使用,应检查是否遗漏了相关的逻辑。
  • ThumbnailListViewAlbum.qml文件中,Share.isFaverDoubleClicked的使用似乎与ThumbnailTools.executeViewImage函数的执行逻辑有关,但当前的调用顺序没有反映这种关系。
  • console.log(Share.isFaverDoubleClicked)在单击模式下被添加,这可能不是必要的,因为Share.isFaverDoubleClicked的值在双击模式下会被改变,但单击模式下的行为尚未明确说明。
  • Share.isFaverDoubleClicked = false;在每次单击事件处理函数中设置为false,这可能不是必要的,因为isFaverDoubleClicked的值在双击模式下会被改变。

是否建议立即修改:

  • 确认ThumbnailListShare.js文件中isFaverDoubleClicked变量的用途,并确保其逻辑正确实现。
  • 重新考虑ThumbnailListViewAlbum.qml文件中Share.isFaverDoubleClicked的使用,确保它与ThumbnailTools.executeViewImage函数的执行逻辑一致。
  • 移除或修改不必要的console.log语句,以避免潜在的调试信息泄露。
  • 检查Share.isFaverDoubleClicked = false;的设置是否合适,因为它可能会导致在单击模式下意外地执行双击操作。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 25, 2024

TAG Bot

New tag: 6.0.10
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants