Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linuxptp and egt-media builds with latest yocto master #240

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Feb 11, 2023

No description provided.

Copy link
Contributor

@gehariprasath gehariprasath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kraj Is it 'videoconvertscale' or 'videocolorscale' ? Release note says it's videocolorscale.
https://gstreamer.freedesktop.org/releases/1.22/

@ldesroches can you review this pls ?

@kraj
Copy link
Contributor Author

kraj commented Feb 13, 2023

@kraj Is it 'videoconvertscale' or 'videocolorscale' ? Release note says it's videocolorscale. https://gstreamer.freedesktop.org/releases/1.22/

the name is what is used in oe-core for this plugin.

@ldesroches can you review this pls ?

Copy link
Contributor

@gehariprasath gehariprasath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thanks for this patch. We have a set of changes queued up internally wherein we have already done this change and PTP is now part of the distribution by default. We have added the same to the package group and hence this is removed. We will be pushing those changes sooner.

Copy link
Contributor

@gehariprasath gehariprasath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kraj We already have 'COMPATIBLE_MACHINE' to restrict only to specific machine type's. So this patch essentially does the same thing, isn't it ?

@kraj
Copy link
Contributor Author

kraj commented Feb 24, 2023

@kraj We already have 'COMPATIBLE_MACHINE' to restrict only to specific machine type's. So this patch essentially does the same thing, isn't it ?

which patch are you referring to ? there are 4 in this PR. Regardless, if you are making recipes to trigger on COMPATIBLE_MACHINE thats fine as long as your intention is not to do so for generic recipes which has no particular reason other than you dont want to fix them for other SOCs. IOW forks of common packages and tools etc.

@gehariprasath
Copy link
Contributor

@kraj We already have 'COMPATIBLE_MACHINE' to restrict only to specific machine type's. So this patch essentially does the same thing, isn't it ?

which patch are you referring to ? there are 4 in this PR. Regardless, if you are making recipes to trigger on COMPATIBLE_MACHINE thats fine as long as your intention is not to do so for generic recipes which has no particular reason other than you dont want to fix them for other SOCs. IOW forks of common packages and tools etc.

It's for the patch titled "optee: Limit sam specific changes to sam alone". This is specific to meta-atmel and our machines. So I guess it won't be a problem for generic recipes.

since gstreamer 1.22 videoconvert/videoscale plgins were merged into one
and main recipe reflects that, therefore adjust accordingly

Fixes
ERROR: QA Issue: egt-media rdepends on gstreamer1.0-plugins-base-videoconvert, but it isn't a build dependency? [build-deps]
ERROR: QA Issue: egt-media rdepends on gstreamer1.0-plugins-base-videoscale, but it isn't a build dependency? [build-deps]

Signed-off-by: Khem Raj <[email protected]>
This ensures that layer can be used along with other ARM BSP layers and
does not insert itself forcefully into those machines

Signed-off-by: Khem Raj <[email protected]>
Fix build with latest setuptools and compiler errors seens with clang 16

Signed-off-by: Khem Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants