Stub Type.GetInterfaceMap on CoreRT #2820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run test-all |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tested stub with sqlite - as expected only 4 tests that use interface mappings failed. Also managed to run some queries in UWP using MS sqlite provider. |
viceroypenguin
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2680
Note that this issue applies only to CoreRT runtime, enabled by
Compile with .NET Native tool chainbuild option.Implementation for this method were added to corert by this PR but it looks like it was never released and whole CoreRT stuff looks like dead horse.
@Daveismus, I'm replacing GetInterfaceMap implementation with noop method, which means you cannot use interfaces in your data model (linq2db will not see them). Another option to make it work is to disable AOT buid for your project...