Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8632] - Use pnpm as our package manager #11297

Draft
wants to merge 50 commits into
base: develop
Choose a base branch
from

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Nov 20, 2024

Description 📝

  • Uses pnpm as our package manager and monorepo tooling 📦

Breaking Changes ⚠️

  • The up script (yarn up) has been removed because it conflicts with pnpm up. Use pnpm dev instead to start the local development environment

Blocked by 🚧

Todo ☑️

  • Update publish-sdk and publish-validation jobs so our publish step does not fail when resolving workspace protocol dependencies (docs)

Risk ⚠️

  • Because we are going to use workspace protocol, we need to change how @linode/api-v4 and @linode/validation are published in our Github Action. If something goes wrong, worst case is that the packages won't get published to npm on our next release. Cloud Manager itself will not be affected.

How to test 🧪

Warning

Work in progress

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai self-assigned this Nov 21, 2024
@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Nov 21, 2024
Copy link

This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days

@github-actions github-actions bot added the Stale label Dec 12, 2024
Copy link

github-actions bot commented Jan 3, 2025

This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days

@github-actions github-actions bot added the Stale label Jan 3, 2025
@bnussman-akamai
Copy link
Member Author

bnussman-akamai commented Jan 14, 2025

dependabot is adding support for bun... I really want to POC bun's package manager before we commit to pnpm

dependabot/dependabot-core#6528 (comment)

Edit: bun still lacks some features that I'd want (for example a --raw / --stream flag)

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 474 passing tests on test run #43 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing474 Passing2 Skipped93m 26s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants