Support DBaaS V2.0 #633
Merged
Support DBaaS V2.0 #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
force-pushed
the
TPT-3298-support-dbaas-v2
branch
from
d7f6e19 to
3ea327d
Compare
ezilber-akamai
force-pushed
the
TPT-3298-support-dbaas-v2
branch
from
8acd7eb to
e94d2a4
Compare
ezilber-akamai
requested review from
jriddle-linode,
zliang-akamai and
lgarber-akamai
and removed request for
a team
ezilber-akamai
added
the
improvement
| Version string `json:"version"` | ||
| ClusterSize int `json:"cluster_size"` | ||
| Platform DatabasePlatform `json:"platform"` | ||
|
|
There was a problem hiding this comment.
Looks like the Port attribute is missing here
There was a problem hiding this comment.
There is a separate ticket to add this field along with several other missing fields across the DBaaS structs. Do you think I should add them all as a part of this PR?
lgarber-akamai
approved these changes
Jan 7, 2025
yec-akamai
added
new-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Implemented changes required to support DBaaS V2
✔️ How to Test
These steps assume you have pulled down this PR locally.
Integration
make ARGS="-timeout 0 -run TestDatabase" fixtures