Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] : use UseURL to correctly parse URLs #630

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rahulait
Copy link
Collaborator

What this PR does / why we need it:
Folks keep on using https://api.linode.com/v4 as LINODE_URL. This URL combines both url and api version. When set with SetBaseURL, it incorrectly adds additional /v4 to the URLs and those API calls will fail. Instead of using SetBaseURL(), we should use UseURL() which correctly parses URLs and then itself calls SetBaseURL.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.42%. Comparing base (7867960) to head (24d0b48).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cloud/scope/common.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   63.44%   63.42%   -0.03%     
==========================================
  Files          70       70              
  Lines        6084     6086       +2     
==========================================
  Hits         3860     3860              
- Misses       1960     1962       +2     
  Partials      264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant