Skip to content

Commit

Permalink
fix: remove index.html from 8-review image
Browse files Browse the repository at this point in the history
The index.html test/validity file shows up when source code mounts are
done into the /app directory, which makes them show up for anyone that
would use this container image as the base layer of a devcontainer.
Can lead to accidental commits.
  • Loading branch information
mhitza committed Sep 8, 2023
1 parent e576542 commit 2b8ff74
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Dockerfile.php8-review
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,8 @@ RUN composer global require icanhazstring/composer-unused \

RUN apt-get update && apt-get install -y python3-pip && python3 -m pip install yamllint --break-system-packages

# Caused the appearance of a git untracked index.html file within the GitHub codespace (when image used as
# the base of a devcontainer)
RUN rm /app/index.html

ENTRYPOINT ["apache2-foreground"]

0 comments on commit 2b8ff74

Please sign in to comment.