Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't actually need this cover image given that we have the video below. #1903

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Jan 2, 2025

Signed-off-by: Flynn [email protected]

@kflynn kflynn requested a review from travisbeckham January 2, 2025 17:53
Copy link
Collaborator

@travisbeckham travisbeckham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting the cover image, we should just remove the showCover: true frontmatter param. This will allow the cover image to be used when the post is shared on social media.

@kflynn
Copy link
Member Author

kflynn commented Jan 2, 2025

I think using the thumbnail is fine for sharing, but I've removed the now-pointless showCover. Thanks for the catch!

Copy link
Collaborator

@travisbeckham travisbeckham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kflynn kflynn merged commit a063526 into main Jan 2, 2025
7 checks passed
@kflynn kflynn deleted the flynn/idp-drop-cover branch January 2, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants