Add egress documentation #1884
Merged
Add egress documentation #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <[email protected]>
kflynn
requested changes
Nov 30, 2024
Co-authored-by: Flynn <[email protected]>
Signed-off-by: Zahari Dichev <[email protected]>
kflynn
requested changes
Dec 4, 2024
Co-authored-by: Flynn <[email protected]>
wmorgan
reviewed
Dec 4, 2024
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
wmorgan
reviewed
Dec 4, 2024
|
|
||
| {{< warning >}} | ||
|
|
||
| No service mesh can provide a strong security guarantee about egress traffic |
There was a problem hiding this comment.
Just fine tuning: Even a meshed application can bypass its proxy in certain conditions, so I would generalize the first statement (cf. https://blog.howardjohn.info/posts/bypass-egress/). I would also probably generalize the last sentence a bit since I am not convinced that just adding CNI config on top of the existing egress setup is by itself sufficient.
Signed-off-by: Flynn <[email protected]>
…gress-docs * 'zd/egress-docs' of github.com:linkerd/website: Rate Limiting docs (#1877) Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
GTRekter
pushed a commit
to GTRekter/website
that referenced
this pull request
Dec 20, 2024
* add egress documentation Signed-off-by: Zahari Dichev <[email protected]> * Apply suggestions from code review by @kflynn Co-authored-by: Flynn <[email protected]> * lint Signed-off-by: Zahari Dichev <[email protected]> * Apply suggestions from code review Co-authored-by: Flynn <[email protected]> * Warnings per William Signed-off-by: Flynn <[email protected]> * Effing lint... Signed-off-by: Flynn <[email protected]> * 🤦♂️ Syntax correctness would help. Signed-off-by: Flynn <[email protected]> * C'mon, lint, tell me all the errors at once... Signed-off-by: Flynn <[email protected]> * Warning tweaks after William's feedback Signed-off-by: Flynn <[email protected]> * 🤦♂️ Signed-off-by: Flynn <[email protected]> --------- Signed-off-by: Zahari Dichev <[email protected]> Signed-off-by: Flynn <[email protected]> Co-authored-by: Flynn <[email protected]> Co-authored-by: Flynn <[email protected]> Signed-off-by: Ivan Porta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zahari Dichev [email protected]