Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add federated services docs #1874

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Add federated services docs #1874

merged 12 commits into from
Dec 4, 2024

Conversation

adleong
Copy link
Member

@adleong adleong commented Nov 8, 2024

No description provided.

wmorgan
wmorgan reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@wmorgan wmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think we need to add a little content in the muclu feature doc too. (There is some unfortunate overlap between that doc and the reference doc... don't feel obligated to solve that larger issue in this PR.)

linkerd.io/content/2-edge/reference/multicluster.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/reference/multicluster.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/reference/multicluster.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/tasks/federated-services.md Outdated Show resolved Hide resolved
@adleong
feedback
0978fa8 
Signed-off-by: Alex Leong <[email protected]>
@adleong
servce
b19fa78 
Signed-off-by: Alex Leong <[email protected]>
kflynn
kflynn requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks suggested but this looks excellent, kudos! 🙂

linkerd.io/content/2-edge/features/multicluster.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/reference/multicluster.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/reference/multicluster.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/reference/multicluster.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/tasks/federated-services.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/tasks/federated-services.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/tasks/federated-services.md Outdated Show resolved Hide resolved
@adleong
Feedback
8839ce1 
Signed-off-by: Alex Leong <[email protected]>
kflynn
kflynn approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, though I've logged a couple of nits. Thanks!! 🙂

linkerd.io/content/2-edge/features/multicluster.md Outdated Show resolved Hide resolved
linkerd.io/content/2-edge/tasks/federated-services.md Outdated Show resolved Hide resolved
@kflynn kflynn merged commit 7a02962 into main Dec 4, 2024
7 checks passed
@kflynn kflynn deleted the alex/federated branch December 4, 2024 17:55
GTRekter pushed a commit to GTRekter/website that referenced this pull request Dec 20, 2024
@adleong @kflynn @alpeb
Add federated services docs (linkerd#1874)
56664d8 
* Add federated services docs

Signed-off-by: Alex Leong <[email protected]>

* feedback

Signed-off-by: Alex Leong <[email protected]>

* servce

Signed-off-by: Alex Leong <[email protected]>

* feedback

Signed-off-by: Alex Leong <[email protected]>

* Feedback

Signed-off-by: Alex Leong <[email protected]>

* Update linkerd.io/content/2-edge/features/multicluster.md

* Update linkerd.io/content/2-edge/tasks/federated-services.md

Co-authored-by: Alejandro Pedraza <[email protected]>

---------

Signed-off-by: Alex Leong <[email protected]>
Co-authored-by: Flynn <[email protected]>
Co-authored-by: Alejandro Pedraza <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpeb alpeb alpeb left review comments

@olix0r olix0r olix0r left review comments

@wmorgan wmorgan wmorgan left review comments

@kflynn kflynn kflynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adleong @wmorgan @olix0r @alpeb @kflynn