Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[da-vinci] Apply Da Vinci record transformer config to associated store only #1393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sixpluszero
Copy link
Contributor

[da-vinci] Apply Da Vinci record transformer config to associated store only

Current code will set DVRT function to ingestion service, and all the store ingestion tasks will share the same DVRT function.
This is not correct if we are running multiple stores with some being DVRT Da Vinci client and some are normal clients.
This PR changes the assumption, and will register the function when a store client is being started.
Also, to support DVRT, we should disable automatic subscription to existing on disk resources during bootstrap stage, as it does not contain DVRT function information. We should rely on user's explicit initialization call to setup function mapping correctly during restart. This PR introduces a method to disable this auto-subscription behavior: "davinci.subscribe.resources.during.bootstrap.enabled", but the default is true, as it is the existing behavior. We will explicitly turn it off when we are spinning up DVRT Da Vinci client.

How was this PR tested?

Adjust integration test and add a new normal client to spin up along with DVRT client and verify the behavior is expected.

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant