[admin-tool] Add a cluster batch processing framework command and a system store empty push task #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixpluszero
force-pushed
the
AdminToolBatchJob
branch
from
53d2c05 to
bd3bc34
Compare
…ystem store empty push task
sixpluszero
force-pushed
the
AdminToolBatchJob
branch
from
bd3bc34 to
10096f7
Compare
sushantmane
reviewed
Dec 17, 2024
| String checkpointFile = getRequiredArgument(cmd, Arg.CHECKPOINT_FILE, Command.CLUSTER_BATCH_TASK); | ||
| int parallelism = Integer.parseInt(getOptionalArgument(cmd, Arg.THREAD_COUNT, "1")); | ||
| System.out.println( | ||
| "[**** Cluster Command Params ****] Cluster: " + clusterName + ", Task: " + task + ", Checkpoint: " |
There was a problem hiding this comment.
Can we use LOGGER to log this info?
| try { | ||
| Path checkpointFilePath = Paths.get(checkpointFile); | ||
| if (!Files.exists(checkpointFilePath.toAbsolutePath())) { | ||
| System.out.println( |
There was a problem hiding this comment.
Maybe use System.err?
| if (SystemStorePushTask.TASK_NAME.equals(task)) { | ||
| functionSupplier = () -> new SystemStorePushTask(controllerClient, controllerClientMap, clusterName); | ||
| } else { | ||
| System.out.println("Undefined task: " + task); |
There was a problem hiding this comment.
Maybe use System.err here as well?
| * This class is a simple runnable which keeps fetching task from list and execute the assigned task. The task fetching | ||
| * and progress tracking / checkpointing is thread-safe, so it can be run in parallel. | ||
| */ | ||
| public class ClusterTaskRunner implements Runnable { |
There was a problem hiding this comment.
Can we change the name of this class to something else? ClusterTaskRunner seems misleading to me
| */ | ||
| public class ClusterTaskRunner implements Runnable { | ||
| private static final Logger LOGGER = LogManager.getLogger(ClusterTaskRunner.class); | ||
| private static final String TASK_LOG_PREFIX = "[**** TASK INFO ****]"; |
There was a problem hiding this comment.
Why do we need TASK_LOG_PREFIX? We can alway grep logs based on the logger name
sushantmane
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Can we scope it to provided system store type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[admin-tool] Add a cluster batch processing framework command and a system store empty push task
This is just a side-effect PR I created for batch processing all stores in cluster when I am empty pushing all system stores to apply config updates.
Add the new command so you can write your store-oriented task and execute it cluster-wide with the admin-tool. It supports basic checkpointing and parallel processing.
With this, there is a system store empty push task in this PR as well, it did sanity checks and empty push to all system stores for a specific user store.
I think it can be further optimized and used for other purpose, but I found it efficient to empty push system store to apply ZK-shared store config update.
How was this PR tested?
This tool has been directly used in test environment and production environment.
Does this PR introduce any user-facing changes?