Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support version notation of intellij plugin #41

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

r-ralph
Copy link
Member

@r-ralph r-ralph commented Oct 15, 2024

There was a mistake in the IntelliJ version notation supported by the IntelliJ plugin, which only supported 241.* versions above 241.18034.
The notation has been corrected to support all IntelliJ versions from version 241 and above.

@r-ralph r-ralph requested a review from munetoshi October 15, 2024 05:48
@r-ralph r-ralph self-assigned this Oct 15, 2024
munetoshi
munetoshi previously approved these changes Oct 15, 2024
Copy link
Contributor

@munetoshi munetoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r-ralph r-ralph requested a review from munetoshi October 15, 2024 06:47
@r-ralph r-ralph dismissed munetoshi’s stale review October 15, 2024 06:48

Fixing verify issues

Copy link
Contributor

@munetoshi munetoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Contributor

@munetoshi munetoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM#

@r-ralph r-ralph merged commit 261a1f8 into line:master Oct 15, 2024
4 checks passed
@r-ralph r-ralph deleted the fix-until-version branch October 15, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants