-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Eureka InstanceInfo to endpoint attribute #6069
Open
Ivan-Montes
wants to merge
2
commits into
line:main
Choose a base branch
from
Ivan-Montes:feature/set-eureka-instanceinfo-to-endpoint-attr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Set Eureka InstanceInfo to endpoint attribute #6069
Ivan-Montes
wants to merge
2
commits into
line:main
from
Ivan-Montes:feature/set-eureka-instanceinfo-to-endpoint-attr
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan-Montes
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
January 13, 2025 08:02
🔍 Build Scan® (commit: b99a0b0) |
minwoox
reviewed
Jan 14, 2025
@@ -399,6 +400,24 @@ public List<Endpoint> apply(byte[] content) { | |||
} | |||
} | |||
|
|||
private static final class EurekaInstanceInfoUtil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's:
- Remove this class because users cannot access this class to retrieve
InstanceInfo
- Move
com.linecorp.armeria.internal.common.eureka.InstanceInfo
tocom.linecorp.armeria.common.eureka.InstanceInfo
- Move the methods to the
InstanceInfo
class - Add a test to verify that users can retrieve the
InstanceInfo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks for the steps. I will work on it.
Related: line#6056 Motivation: Users might want to use the metadata from the Eureka `InstanceInfo` but currently, there's no way to retrieve it. Modifications: - Add a helper class to hide the implementation detail. - Set the `InstanceInfo` to the `Endpoint` as an attribute. Result: - Closes line#6056 - Now users can retrieve it.
Related: line#6056 Motivation: Users might want to use the metadata from the Eureka `InstanceInfo` but currently, there's no way to retrieve it. Modifications: - Remove helper class because users cannot access this class to retrieve `InstanceInfo`. - Move `com.linecorp.armeria.internal.common.eureka.InstanceInfo` to `com.linecorp.armeria.common.eureka.InstanceInfo`. - Move the methods to the `InstanceInfo` class. - Add a test to verify that users can retrieve the `InstanceInfo`. Result: - Closes line#6056 - Now users can retrieve it.
Ivan-Montes
force-pushed
the
feature/set-eureka-instanceinfo-to-endpoint-attr
branch
from
January 14, 2025 14:51
29d007a
to
b99a0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6056
Motivation:
Users might want to use the metadata from the Eureka
InstanceInfo
but currently, there's no way to retrieve it.Modifications:
InstanceInfo
to theEndpoint
as an attribute.Result: