Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal set of fixes to get tests passing in julia 0.5 #18

Closed
wants to merge 1 commit into from

Conversation

Cody-G
Copy link

@Cody-G Cody-G commented Jan 23, 2017

@Cody-G Cody-G closed this Jan 26, 2017
@Cody-G Cody-G reopened this Jan 26, 2017
@Cody-G Cody-G closed this Feb 20, 2017
@Cody-G Cody-G reopened this Feb 20, 2017
@merl-dev
Copy link

merl-dev commented Feb 24, 2017

The package will pass all tests with a more minimalist set of changes:

  1. delete dependence on ArrayViews (in Regression.jl line 4)
  2. replace line 15 in src/common.jl with fill!(view(Xa, m+1, :), v)
  3. keep your bug fix in test/linearreg.jl line 13

As per the ArrayViews README:

By and large, this package is no longer necessary: base julia now has efficient SubArrays (i.e., sub and slice)

@Cody-G
Copy link
Author

Cody-G commented Mar 13, 2017

@merl-dev you are totally right, see my new PR #19

@Cody-G Cody-G closed this Mar 13, 2017
@merl-dev
Copy link

To get it through Travis you may want to remove the "nightly" from the travis file.

You can also remove ArrayViews from REQUIRE.

I also have a branch EmpriricalRisks/rem_arrayviews that also replaces ArrayViews.

(I've only made these updates locally as I plow through the package history for doing this kind of work. You might want to consider upgrading to newer, maintained packages)

@Cody-G
Copy link
Author

Cody-G commented Mar 13, 2017 via email

@merl-dev
Copy link

merl-dev commented Mar 13, 2017

No but you can look at GLMNet, of which there are 2 versions, fortran based and pure Julia, Lasso.jl ... you could also look into the tool kits provided through JuliaML, JuMP ... where there is a ton of active development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants