Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename yamls #29

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Rename yamls #29

merged 9 commits into from
Jan 12, 2024

Conversation

OliviaLynn
Copy link
Member

Now that we'll have just update_dashboard and not update_dashboard_group as well (same for index, index_group), I'm removing deprecated yamls and renaming the former *_group yamls to match our other renaming.

With update_dashboard_group becoming update_dashboard (same for index_group to index, etc), I'm removing deprecated yamls and renaming the ones we'll be using to match.

Base automatically changed from delucchi/v1 to main January 11, 2024 18:14
@delucchi-cmu
Copy link
Contributor

I think you'll also want to make changes in:

  • tests/lf_workflow_dash/test_module_action.py
  • .github/workflows/main.yml

And I'm not sure why the unit test workflow didn't run? It would have failed with the missing yaml files...

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f383fa7) 58.91% compared to head (246ac66) 58.91%.

❗ Current head 246ac66 differs from pull request most recent head 647cbcc. Consider uploading reports for the commit 647cbcc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   58.91%   58.91%           
=======================================
  Files           3        3           
  Lines         129      129           
=======================================
  Hits           76       76           
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OliviaLynn OliviaLynn merged commit cb69567 into main Jan 12, 2024
4 checks passed
@OliviaLynn OliviaLynn deleted the rename-yamls branch January 12, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants