Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PART 2] Migrate dev-features to dev #2826

Merged
merged 15 commits into from
May 27, 2024
Merged

[PART 2] Migrate dev-features to dev #2826

merged 15 commits into from
May 27, 2024

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Apr 24, 2024 •
edited
Loading

Issues

  • Part of the content is lost when replying or forwarding emails
  • The editor background appears gray when the waning dialog appears
  • Overflow height delete identity dialog on mobile
  • Avoid fetching again identity lists in SingleEmailController

Dependent

Resolved

  • Part of the content is lost when replying or forwarding emails
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-24.at.08.36.46.mp4
  • The editor background appears gray when the waning dialog appears
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-25.at.10.07.03.mp4

Related

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/2826.

@dab246 dab246 changed the base branch from migrate-dev-features to v0.11.3-patch4-dev April 26, 2024 08:20
@dab246 dab246 force-pushed the migrate-dev-features-part-2 branch from a65671a to 29de0cb Compare April 26, 2024 08:29
@hoangdat
Copy link
Member

Still found the cut in composer Android

IMG_4402

@hoangdat
Copy link
Member

  • cancel sending or saving draft, composer will be closed -> please avoid it

@dab246
Copy link
Member Author

dab246 commented Apr 26, 2024 •
edited
Loading

  • cancel sending or saving draft, composer will be closed -> please avoid it

Fixed, please see video demo below:

  • Web
Screen.Recording.2024-04-26.at.18.36.40.mov
  • Mobile
demo-mobile.webm
  • Sending offline
Screen_recording_20240426_185308.webm

@hoangdat
Copy link
Member

  • close composer, save dialog show, click on back button -> can not show saving dialog anymore

@dab246
Copy link
Member Author

dab246 commented Apr 29, 2024

  • close composer, save dialog show, click on back button -> can not show saving dialog anymore

Please attach video demo. thanks.

@dab246
Copy link
Member Author

dab246 commented May 2, 2024 •
edited
Loading

[x] close composer, save dialog show, click on back button -> can not show saving dialog anymore

Fixed. Please see video demo below

Screen_recording_20240502_152831.webm

@hoangdat
Copy link
Member

hoangdat commented May 3, 2024 •
edited by tddang-linagora
Loading

  • test in Android, email which have very long and rich html: reply many times @tddang-linagora

@tddang-linagora
Copy link
Contributor

  • test in Android, email which have very long and rich html: reply many times @tddang-linagora
test.long.email.reply.mp4

@dab246
Copy link
Member Author

dab246 commented May 7, 2024

  • optimize query components
  • transformer to remove lazy load -> add it to

Please attach demo video after fixed lazy loading

@tddang-linagora
Copy link
Contributor

  • optimize query components
  • transformer to remove lazy load -> add it to

Please attach demo video after fixed lazy loading

RPReplay_Final1714977866.mp4

@tddang-linagora
Copy link
Contributor

Quoted content is clipped before signature loaded

Record_2024-05-08-15-34-51.mp4

@tddang-linagora
Copy link
Contributor

Work around - Show toast

Screen.Recording.2024-05-09.at.15.18.11.mov

@hoangdat
Copy link
Member

Crashed eml when open
Crashed_20240520-Re_Fwd_ 📢 USDC on Polkadot _ 8x Scalability Update _ Blockspace Explained-1148.eml.zip

Reproduce step:

  1. open message: original.eml.zip
  2. load message completed in email view
  3. reply
  4. send when this message is not load completed in composer
  5. open sent folder -> open mail from sent -> crashed
Screenrecorder-2024-05-20-15-17-22-206.mp4

@hoangdat
Copy link
Member

  • mail is stuck in loading in composer. Always show toast Email content is being loaded.
    Fx: medium in Vietnam.

@dab246 dab246 force-pushed the migrate-dev-features-part-2 branch from 9b89c8b to d18942d Compare May 21, 2024 07:46
@dab246
Copy link
Member Author

dab246 commented May 21, 2024

Crashed eml when open Crashed_20240520-Re_Fwd_ 📢 USDC on Polkadot _ 8x Scalability Update _ Blockspace Explained-1148.eml.zip

Reproduce step:

  1. open message: original.eml.zip
  2. load message completed in email view
  3. reply
  4. send when this message is not load completed in composer
  5. open sent folder -> open mail from sent -> crashed

Screenrecorder-2024-05-20-15-17-22-206.mp4

Cannot reproduce on virtual machine. Testing on real device Oppo F7

  • mail is stuck in loading in composer. Always show toast Email content is being loaded.
    Fx: medium in Vietnam.

Fixed

demo.online-video-cutter.com.mp4

@hoangdat hoangdat mentioned this pull request May 22, 2024
Closed
@hoangdat
Copy link
Member

I still have stuck when some content is blocked to fetch

Screenrecorder-2024-05-22-18-51-02-99.mp4

@dab246
Copy link
Member Author

dab246 commented May 23, 2024

I still have stuck when some content is blocked to fetch

Screenrecorder-2024-05-22-18-51-02-99.mp4

Please fetch latest commit to test again.

@dab246 dab246 force-pushed the migrate-dev-features-part-2 branch from d18942d to 493d9f9 Compare May 24, 2024 09:40
@dab246
Copy link
Member Author

dab246 commented May 24, 2024

  • Fix crash when open composer on Android 12 (Xiaomi)
demo.online-video-cutter.com.mp4
  • Fix size Discard Change button in dialog composer
Screen_recording_20240524_163336.webm

@hoangdat Please help me test again on your Xiaomi device. Thanks.

@hoangdat hoangdat merged commit fe4b4da into v0.11.3-patch4-dev May 27, 2024
14 checks passed
@dab246 dab246 mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tddang-linagora tddang-linagora tddang-linagora approved these changes

@hoangdat hoangdat hoangdat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dab246 @hoangdat @tddang-linagora