Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soul Fire'd compat update for v4.0.0 #113

Open
Crystal-Spider opened this issue Jun 21, 2024 · 3 comments · May be fixed by #118
Open

Soul Fire'd compat update for v4.0.0 #113

Crystal-Spider opened this issue Jun 21, 2024 · 3 comments · May be fixed by #118

Comments

@Crystal-Spider
Copy link

Hi! I'm Soul Fire'd dev, and first of all thank you for adding compatibility with my mod!

Recently I updated SF to a multiloader environment. With this update, I also changed the mod ID from soulfired to soul_fire_d.
I could see that you used a platform service to abstract SF logic, but now the API has been moved to common.

Moreover, SF gradle dependency needs to be added differently. Here you can find the step-by-step procedure.

Let me know if you can fix it yourself or if you would prefer a PR to update, however please consider that I'm a bit tight with time currently and it might take some days before I can work on a PR.

Thank you again!

@VoidLeech
Copy link

I tried my hand at making a PR since I'd love the compat working again, seeing I originally requested it. Working from the default branch atm (totally not biased due to playing 1.20.1 right now): 1.20...VoidLeech:Decorative-Blocks:1.20

There's quite some buildscript that needs updating. Loom needs a bump (to 1.5-SNAPSHOT) to deal with Mixin remapping on the Fabric side, so gradle needs a bump (to 8.5). The foojay resolver needs a bump (to 0.8.0) to deal with an IllegalAccessException.

Bumping gradle means registrationutils needs a bump (NoSuchMethod) and now requires the org.jetbrains.gradle.plugin.idea-ext plugin.

But with the registrationutils bump we run into Matyrobbrt/RegistrationUtils#14 SpongePowered/MixinGradle#55 on the Forge side.

So the only road forward seems to be ripping out that library, which is where I'm at right now (and seems to have been done for 1.20.4 anyway as well due to it not existing there).

@lilypuree
Copy link
Owner

I've been working on that but had to stop due to mental health issues. Working on a PR would be a waste of your time. Sorry.

@VoidLeech
Copy link

Hey, that's alright, take care of yourself! Do let know if you would want to see a PR because I don't think it seems too daunting a task.

@VoidLeech VoidLeech linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants