Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token endpoint auth method fix and logout fix #131

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

tom-sherman
Copy link
Contributor

@tom-sherman tom-sherman commented Sep 26, 2024

This also changes the behaviour of login for some reason: you no longer need to accept the permissions every time you login.

Closes #128

Verified

This commit was signed with the committer’s verified signature.
tom-sherman Tom Sherman

Verified

This commit was signed with the committer’s verified signature.
tom-sherman Tom Sherman

Verified

This commit was signed with the committer’s verified signature.
tom-sherman Tom Sherman
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontpage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 6:13pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
atproto-browser ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:13pm
unravel ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 6:13pm

@@ -133,7 +133,6 @@ async function LoginOrLogout() {
await signOut();
deleteAuthCookie(cookies());
revalidatePath("/", "layout");
redirect("/");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this because there's a bug in next.js that doesn't revalidate layouts when combined with a redirect.

vercel/next.js#70483

Verified

This commit was signed with the committer’s verified signature.
tom-sherman Tom Sherman
@tom-sherman tom-sherman merged commit e88fc19 into main Sep 26, 2024
7 checks passed
@tom-sherman tom-sherman deleted the token_endpoint_auth_method-fix branch September 26, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

token_endpoint_auth_method probably shouldn't be unset like this
2 participants