Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[abandoned]route: Add onion blob to sendtoroute #6750

Closed
wants to merge 1 commit into from

Conversation

ErikEk
Copy link
Contributor

@ErikEk ErikEk commented Jul 18, 2022

This PR adds the ability to parse a custom onion blob to sendtoroute. The blob is limited to 1366 bytes for now.
Partly closes #6206:

  • Add a new OnionBlob field to the SendToRoute RPC call. If present, normal path to onion blob compilation can be skipped.
  • Add a similar field to SendPaymentV2. In this case path finding should be skipped all together and the onion blob used in place. Note that since we can't decode the error retries as we handle them today aren't possible. Instead we may need some custom retry hooks, or just decide that this feature will be only added to SendToRoute.
  • Create provisions in the current APIs to allow for delegated error processing, if we wish to propagate any learnings from the path finding attempt into the internal mission control store.

@ErikEk ErikEk changed the title [WIP] Route: Add onion blob to sendtoroute [WIP] route: Add onion blob to sendtoroute Jul 18, 2022
@ErikEk ErikEk force-pushed the route-add-onion-blob branch 2 times, most recently from 63aa473 to e057843 Compare July 18, 2022 20:04
@Roasbeef Roasbeef added this to the v0.16.0 milestone Jul 19, 2022
@ErikEk ErikEk force-pushed the route-add-onion-blob branch 4 times, most recently from 808ba16 to 15d156c Compare August 6, 2022 07:52
@ErikEk ErikEk force-pushed the route-add-onion-blob branch from 15d156c to 50d3968 Compare August 19, 2022 08:21
@ErikEk ErikEk marked this pull request as ready for review August 19, 2022 08:25
@ErikEk ErikEk changed the title [WIP] route: Add onion blob to sendtoroute route: Add onion blob to sendtoroute Aug 19, 2022
@saubyk saubyk removed this from the v0.16.0 milestone Aug 27, 2022
@ErikEk ErikEk force-pushed the route-add-onion-blob branch from 50d3968 to adb8116 Compare September 15, 2022 06:59
Copy link
Collaborator

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, will be a very useful feature! I left a comment in the original issue, happy to know your opinion about it.

@ErikEk
Copy link
Contributor Author

ErikEk commented Oct 9, 2022

@bitromortac Thank for letting me know. I'll get back to you.

Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will read @bitromortac 's comments and then come back. Just FYI #6683 will largely change the code here.

cmd/lncli/cmd_payments.go Outdated Show resolved Hide resolved
docs/release-notes/release-notes-0.16.0.md Outdated Show resolved Hide resolved
@ErikEk ErikEk force-pushed the route-add-onion-blob branch from adb8116 to 6abf4a6 Compare October 31, 2022 09:26
@ErikEk
Copy link
Contributor Author

ErikEk commented Mar 6, 2023

This is up for grab, right now, if anyone wants to continue the work.

@bitromortac
Copy link
Collaborator

!lightninglabs-deploy mute

Disabling the bot until more work is added here.

@lightninglabs-deploy
Copy link

@ErikEk, remember to re-request review from reviewers when ready

@yyforyongyu
Copy link
Member

!lightninglabs-deploy mute 30d

@ErikEk ErikEk marked this pull request as draft July 10, 2023 18:58
@SeverinAlexB
Copy link

Hi @ErikEk,
The LSPSpec LSPS2 might require sending custom onions. Can you give me an update on the state of this PR?

Thanks
Sev

@ErikEk
Copy link
Contributor Author

ErikEk commented Jul 20, 2023

This is up for grab, right now, if anyone wants to continue the work.

Hi,
I did abandon this pr.

@ErikEk ErikEk changed the title route: Add onion blob to sendtoroute [abandoned]route: Add onion blob to sendtoroute Jul 20, 2023
@guggero guggero added the up for grabs PRs which have been abandoned by their original authors and can be taken up by someone else label Jul 20, 2023
@guggero
Copy link
Collaborator

guggero commented Jul 20, 2023

@SeverinAlexB feel free to take over the PR if you're interested. Going to close it, the state should be pretty clear from the title and the tags.

@guggero guggero closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up for grabs PRs which have been abandoned by their original authors and can be taken up by someone else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc+routing: extend SendToRoute/SendPaymentV2 RPCs with new field allowing custom onion specification
8 participants