-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[abandoned]route: Add onion blob to sendtoroute #6750
Conversation
63aa473
to
e057843
Compare
808ba16
to
15d156c
Compare
15d156c
to
50d3968
Compare
50d3968
to
adb8116
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, will be a very useful feature! I left a comment in the original issue, happy to know your opinion about it.
@bitromortac Thank for letting me know. I'll get back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will read @bitromortac 's comments and then come back. Just FYI #6683 will largely change the code here.
adb8116
to
6abf4a6
Compare
This is up for grab, right now, if anyone wants to continue the work. |
!lightninglabs-deploy mute Disabling the bot until more work is added here. |
@ErikEk, remember to re-request review from reviewers when ready |
!lightninglabs-deploy mute 30d |
Hi @ErikEk, Thanks |
Hi, |
@SeverinAlexB feel free to take over the PR if you're interested. Going to close it, the state should be pretty clear from the title and the tags. |
This PR adds the ability to parse a custom onion blob to
sendtoroute
. The blob is limited to 1366 bytes for now.Partly closes #6206:
OnionBlob
field to theSendToRoute
RPC call. If present, normal path to onion blob compilation can be skipped.SendPaymentV2
. In this case path finding should be skipped all together and the onion blob used in place. Note that since we can't decode the error retries as we handle them today aren't possible. Instead we may need some custom retry hooks, or just decide that this feature will be only added toSendToRoute
.