Add general RFQ accept wire msg type #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a quote accept message type which serves as a single wire message type for both buy and sell quote accept messages.
Type `sellAcceptMsgData` is redundant and can be removed following the introduction of type `acceptWireMsgData`.
Type `buyAcceptMsgData` is redundant and can be removed following the introduction of type `acceptWireMsgData`.
The `AssetAmount` field is redundant as it is a copy of the value found in `rfqmsg.BuyAccept.Request.AssetAmount`. It is therefore removed in this commit.
The `AssetAmount` field is redundant as it is a copy of the value found in `rfqmsg.SellAccept.Request.AssetAmount`. It is therefore removed in this commit.
guggero
approved these changes
Jun 7, 2024
| // Sig is a signature over the serialized contents of the message. | ||
| Sig tlv.RecordT[tlv.TlvType3, [64]byte] | ||
|
|
||
| InOutRateTick acceptInOutRateTick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #914
This is the final PR towards closing #914 .
This PR introduces a new quote accept wire message type that can be used by both buy and sell accept messages. Effectively using a single wire message type for both buy and sell.
In this PR we also remove a redundant field from the buy/sell message types.