Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: RFQ Wire message updates: split asset_amt, implicit asset_id types reduction #914

Closed
6 tasks
dstadulis opened this issue May 23, 2024 · 0 comments · Fixed by #937
Closed
6 tasks
Assignees
Labels
bLIP enhancement New feature or request rfq
Milestone

Comments

@dstadulis
Copy link
Collaborator

dstadulis commented May 23, 2024

Background

Roasbeef/blips#3 (comment)

TODO Scope

  • Split the asset_amt field
  • Use only 3 different wire message types (from in situ 5) to handle:
    • If in_asset_id (e.g. USD-X) is only specified
      • In LN setting, it's a quote for receiving asset_id
    • If out_asset_id is only specified
      • In LN setting, it's a quote for sending asset_id

Before this change, asset_amt was the amount of USD (or w/e) tied to the invoice. So we were asking for a price quote in BTC/asset_id.

Example user swap flows to confirm wire message reduction

[edit at will]

@dstadulis dstadulis added enhancement New feature or request bLIP rfq labels May 23, 2024
@dstadulis dstadulis added this to the v0.4 milestone May 23, 2024
@dstadulis dstadulis moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board May 23, 2024
@dstadulis dstadulis changed the title [feature]: RFQ Wire message updates: split asset_amt, implicit asset_id types reduction [feature]: RFQ Wire message updates: split asset_amt, implicit asset_id types reduction May 23, 2024
@dstadulis dstadulis moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Jun 4, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bLIP enhancement New feature or request rfq
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants