Fix release workflow #237
Merged
Fix release workflow #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epeters3
commented
Dec 17, 2024
| @@ -12,8 +13,7 @@ if does_pypi_version_exist phc "$pkg_version"; then | |||
| fi | |||
|
|
|||
| echo "Building the package" | |||
| poetry build -f sdist | |||
| poetry build -f wheel | |||
| poetry build | |||
There was a problem hiding this comment.
poetry build automatically builds both the sdist and the wheel.
jagoda
approved these changes
Dec 18, 2024
shawnzhu
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With my last PR the release workflow broke. It looked like an incompatibility between Poetry 1.8.5 and twine 4.x. This PR updates the release workflow to use the more modern and streamlined workflow used by other projects like
chatbot-tools-pyandpatient-ml-types.