Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add color prop to <Chip and adjust styles #423

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

dexterca
Copy link
Member

@dexterca dexterca commented Jan 15, 2025

  • Add color prop
  • Remove bold font weight
  • Adjust size, padding and positioning of delete button
  • Adjust delete icon size and stroke-width
  • Leverage gap vs margin for spacing on multiple <Chips

NOTE: Different color hover states have been accounted for in this PR just not shown below in screenshots.

  BEFORE AFTER
default Screenshot 2025-01-15 at 10 07 03 AM Screenshot 2025-01-15 at 9 56 14 AM
default hover Screenshot 2025-01-15 at 10 07 09 AM Screenshot 2025-01-15 at 10 09 12 AM
primary n/a Screenshot 2025-01-15 at 9 56 21 AM
negative n/a Screenshot 2025-01-15 at 9 56 41 AM
positive n/a Screenshot 2025-01-15 at 9 56 45 AM
inverse n/a Screenshot 2025-01-15 at 9 56 29 AM
warning n/a Screenshot 2025-01-15 at 9 56 49 AM

@dexterca dexterca marked this pull request as ready for review January 15, 2025 15:16
@dexterca dexterca merged commit ac2a86f into master Jan 15, 2025
7 checks passed
@dexterca dexterca deleted the chip-styles branch January 15, 2025 16:14
Copy link

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants