Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PHC-4380): avoid break change in type #337

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

shawnzhu
Copy link
Member

Before

After merging of #333, type TableConfiguration<Item> will require one type argument, which will break all applications that uses TableModule.

After

type TableConfiguration<Item> will not require any type argument, it could use TableConfiguration<RowSelectionRow> when using the row selection API.

Copy link

@simons5593 simons5593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2c.

src/components/TableModule/types.ts Show resolved Hide resolved
src/components/TableModule/types.ts Show resolved Hide resolved
Copy link

@simons5593 simons5593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info on my questions! LGTM!

@shawnzhu shawnzhu merged commit 5137a9f into master Mar 27, 2023
@shawnzhu shawnzhu deleted the PHC-4380-non-break-api branch March 27, 2023 14:15
@github-actions
Copy link

🎉 This PR is included in version 4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants