fix: include method and url in request error message #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epeters3
commented
Aug 22, 2024
| default: | ||
| throw new Error( | ||
| 'Unhandled responseType requested: ' + config.responseType, | ||
| ); |
There was a problem hiding this comment.
No functional changes here^, just Prettier.
epeters3
force-pushed
the
EOCI-117/improve-error-messages
branch
from
a6ed600 to
5461b68
Compare
epeters3
commented
Aug 22, 2024
jkdowdle
approved these changes
Aug 22, 2024
jagoda
approved these changes
Aug 22, 2024
|
🎉 This PR is included in version 6.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes I see errors like this in logs:
These^ error messages don't give any info about which line threw the error, or what Lambda URL was being called. This change will make that error message look like
Error: Request GET lambda://test-function/some/path failed with status code 400, which provides more helpful debug information.