Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [pt. 2] support alpha release #170

Merged
merged 1 commit into from
Feb 22, 2024
Merged

chore: [pt. 2] support alpha release #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- 'master'
- 'alpha'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the alpha branch be used for 0.28? I guess I expected new release branches for each < 1.x axios release.

Copy link
Member Author

@aecorredor aecorredor Feb 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this repo is already using semantic release, and the main line is already above 1.x, my plan was to support versions >= 0.28 <= 1.x as alpha pre-release versions, which we'd also support via semantic release by using the alpha branch - See this.

When you say new release branches, do you just mean to push this change to the main line? (that would mean just downgrading the axios version, right?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't make the assumption that they'd avoid breaking change in 0.29, 0.30, etc. If you think they'll keep API compatibility for all new < 1.x releases your approach makes sense.

Worst case, you could make your assumption for now and introduce a new branch if they break compatibility. Hopefully it doesn't happen.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, like you said, I'm being optimistic about them sticking to real semver...


jobs:
build:
Expand Down
Loading