Supports [email protected] #165

shawnzhu · 2023-11-13T22:15:37Z

Follow up of #164

There're several break changes on types and API.

it will need to implement axios/lib/helpers/buildURL since it could not be imported from axios anymore. see kuitos/axios-extensions#99

Bumps [axios](https://github.com/axios/axios) from 0.27.2 to 1.6.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.27.2...v1.6.0) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>

mdlavin · 2023-11-13T22:45:47Z

src/adapters/response-retry.ts

  if (error.isLambdaInvokeTimeout) return true;

-  return error.code !== 'ECONNABORTED' &&
-    (!error.response || (error.response.status >= 500 && error.response.status <= 599));
+  return error.code !== 'ECONNABORTED' && isServerSideError(error);


Should this be ! isServerSideError ?

No, I don't think so. My mistake

mdlavin · 2023-11-13T22:47:34Z

src/adapters/response-retry.ts

+  return (
+    error.response
+    && (
+      _inRange(_get(error.response, 'StatusCode', 0) as number, 500, 600)


Before the addition of StatusCode checks, was this function failing to detect some failures?

this function is refactored from isRetryableError(). it checked the statusCode of http request via Axios API (AxiosResponse) only.

These lines are for checking the status code of lambda function invocation via Lambda API (InvocationResponse). I could remove this one if aws internal error during lambda invocation is not retryable.

test/adapters/helpers/apiGateway.test.ts

test/alpha.test.ts

test/retry.test.ts

shawnzhu · 2023-11-14T13:59:18Z

src/adapters/response-retry.ts

+  return (
+    error.response
+    && (
+      _inRange(_get(error.response, 'StatusCode', 0) as number, 500, 600)


this function is refactored from isRetryableError(). it checked the statusCode of http request via Axios API (AxiosResponse) only.

These lines are for checking the status code of lambda function invocation via Lambda API (InvocationResponse). I could remove this one if aws internal error during lambda invocation is not retryable.

src/resolve.ts

test/adapters/helpers/apiGateway.test.ts

test/alpha.test.ts

shawnzhu · 2023-11-14T17:54:03Z

Progress

after bd7aa1c it will pass all unit tests (fell short on code coverage a little bit).
It allows using empty object to declare headers so no changes to Alpha API.

tsc --noEmit fails. I still need to fix the types since the assumption is it declares AlphaResponse.config in type AlphaOptions, which is not strict enogh.

.github/workflows/pr-branch-build.yaml

mdlavin · 2023-11-14T18:26:29Z

Can you push a commit marked as breaking so the version number will be bummed?

shawnzhu · 2023-11-14T19:22:42Z

Can you push a commit marked as breaking so the version number will be bummed?

will do in a coming commit that fixes types.

lifeomic-probot · 2023-11-14T20:34:49Z

⚠️ Detected a breaking change in commit 642b298

Merging this PR will result in a major version bump.

Created by lifeomic-probot (Enforce Semantic Commits)

shawnzhu · 2023-11-14T20:38:45Z

src/types.ts

@@ -14,7 +14,7 @@ type SignatureV4Constructor = SignatureV4Init & SignatureV4CryptoInit;
 type SignatureV4Optionals = 'credentials' | 'region' | 'sha256' | 'service';

 export interface AlphaResponse<ResponseData = any, ConfigData = any> extends AxiosResponse<ResponseData> {
-  config: AlphaOptions<ConfigData>;
+  config: AlphaOptions<ConfigData> & InternalAxiosRequestConfig;


This change means it could re-use AlphaOptions as the type of config in AlphaResponse but response headers always exist.

shawnzhu · 2023-11-14T20:40:40Z

package.json

-    "@lifeomic/eslint-config-standards": "^3.0.0",
-    "@lifeomic/jest-config": "^1.1.2",
-    "@lifeomic/typescript-config": "^1.0.3",
+    "@lifeomic/eslint-config-standards": "3.0.0",


I locked it to 3.0.0 to be able to run yarn lint on node.js v14.

shawnzhu · 2023-11-14T20:51:41Z

Notice that it will need to port this change to @lifeomic/[email protected] release as a maintenance release for projects still uses aws-sdk v2

mdlavin · 2023-11-14T22:01:26Z

Notice that it will need to port this change to @lifeomic/[email protected] release as a maintenance release for projects still uses aws-sdk v2

I had the same thought, but it's a bummer that the upgrade is a breaking change. Ideally we'd somehow introduce a major version change between 4 and 5 😄

src/types.ts

swain

Nice. This upgrade has been a long time coming. Thanks for doing the tedious work!

github-actions · 2023-11-15T19:22:39Z

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

dependabot bot and others added 2 commits November 11, 2023 04:17

feat: supports [email protected]

728ba11

shawnzhu added the enhancement New feature or request label Nov 13, 2023

shawnzhu mentioned this pull request Nov 13, 2023

build(deps): bump axios from 0.27.2 to 1.6.0 #164

Merged

mdlavin reviewed Nov 13, 2023

View reviewed changes

feat: stops support node v14

1b58338

shawnzhu commented Nov 14, 2023

View reviewed changes

shawnzhu force-pushed the upgrade-deps branch 6 times, most recently from e7c5ddd to cbdd5e9 Compare November 14, 2023 18:12

fix: pass all unit tests

20c701b

shawnzhu force-pushed the upgrade-deps branch from cbdd5e9 to 20c701b Compare November 14, 2023 18:13

mdlavin reviewed Nov 14, 2023

View reviewed changes

.github/workflows/pr-branch-build.yaml Outdated Show resolved Hide resolved

shawnzhu force-pushed the upgrade-deps branch 2 times, most recently from f2457c7 to eefbbf1 Compare November 14, 2023 19:04

fix: supports node v14

c042dae

shawnzhu force-pushed the upgrade-deps branch from eefbbf1 to c042dae Compare November 14, 2023 19:05

feat!: fix types to support [email protected]

642b298

shawnzhu marked this pull request as ready for review November 14, 2023 20:37

shawnzhu commented Nov 14, 2023

View reviewed changes

shawnzhu requested a review from mdlavin November 14, 2023 20:41

shawnzhu added the dependencies Pull requests that update a dependency file label Nov 14, 2023

shawnzhu requested review from swain and rob-snyder November 14, 2023 21:40

swain reviewed Nov 15, 2023

View reviewed changes

src/types.ts Outdated Show resolved Hide resolved

src/types.ts Outdated Show resolved Hide resolved

shawnzhu added 4 commits November 15, 2023 11:52

fix: adjust type naming

06b3b0d

fix: improves type

f9a58ed

fix: improves type from feedback

0690f50

fix: reuses redeclared types

0bf1586

swain approved these changes Nov 15, 2023

View reviewed changes

shawnzhu merged commit e4adaed into master Nov 15, 2023
5 checks passed

shawnzhu deleted the upgrade-deps branch November 15, 2023 19:21

github-actions bot added the released label Nov 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Supports [email protected] #165

Supports [email protected] #165

shawnzhu commented Nov 13, 2023

mdlavin Nov 13, 2023

mdlavin Nov 13, 2023

mdlavin Nov 13, 2023

shawnzhu Nov 14, 2023

shawnzhu Nov 14, 2023

shawnzhu commented Nov 14, 2023

mdlavin commented Nov 14, 2023

shawnzhu commented Nov 14, 2023

lifeomic-probot bot commented Nov 14, 2023 •

edited

Loading

shawnzhu Nov 14, 2023

shawnzhu Nov 14, 2023

shawnzhu commented Nov 14, 2023

mdlavin commented Nov 14, 2023

swain left a comment

github-actions bot commented Nov 15, 2023

Supports [email protected] #165

Supports [email protected] #165

Conversation

shawnzhu commented Nov 13, 2023

mdlavin Nov 13, 2023

Choose a reason for hiding this comment

mdlavin Nov 13, 2023

Choose a reason for hiding this comment

mdlavin Nov 13, 2023

Choose a reason for hiding this comment

shawnzhu Nov 14, 2023

Choose a reason for hiding this comment

shawnzhu Nov 14, 2023

Choose a reason for hiding this comment

shawnzhu commented Nov 14, 2023

Progress

mdlavin commented Nov 14, 2023

shawnzhu commented Nov 14, 2023

lifeomic-probot bot commented Nov 14, 2023 • edited Loading

shawnzhu Nov 14, 2023

Choose a reason for hiding this comment

shawnzhu Nov 14, 2023

Choose a reason for hiding this comment

shawnzhu commented Nov 14, 2023

mdlavin commented Nov 14, 2023

swain left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 15, 2023

lifeomic-probot bot commented Nov 14, 2023 •

edited

Loading