feat: duplicated vetted keys checks #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddort
reviewed
Dec 4, 2023
src/guardian/staking-module-guard/staking-module-guard.service.ts
Outdated
Show resolved
Hide resolved
src/guardian/staking-module-guard/staking-module-guard.service.ts
Outdated
Show resolved
Hide resolved
eddort
reviewed
Dec 7, 2023
src/guardian/staking-module-guard/staking-module-guard.service.ts
Outdated
Show resolved
Hide resolved
eddort
reviewed
Dec 7, 2023
src/guardian/staking-module-guard/staking-module-guard.service.ts
Outdated
Show resolved
Hide resolved
|
It looks good, but I want to take another look tomorrow morning |
eddort
reviewed
Dec 8, 2023
src/guardian/staking-module-guard/staking-module-guard.service.ts
Outdated
Show resolved
Hide resolved
e2e for duplicated keys check and invalid keys
fix: added cache
…check Added validation check in staking router guards checks
…eys-validation-multithread
…eys-validation-multithread
…-497-kapi-reorg-fix
lastChangedBlockHash
…-multithread keys validation multithread
eddort
reviewed
Dec 23, 2023
src/guardian/staking-module-guard/staking-module-guard.service.ts
Outdated
Show resolved
Hide resolved
eddort
approved these changes
Dec 24, 2023
|
It would be nice to write more tests for key validation in the future |
eddort
approved these changes
Dec 25, 2023
F4ever
reviewed
Dec 26, 2023
src/guardian/staking-module-guard/staking-module-guard.service.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.