fix: incorrect ports in docker-compose
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request #202 introduced a bug with port variables substitution in the `docker-compose.yml` file. Because of this bug clickhouse was not running correctly in a docker container. Now this bug is fixed.
As stated in Readme, `HTTP_PORT` environment variable should be optional and have a reasonable default value. But in the previous version of `docker-compose` file it was assumed that the `HTTP_PORT` value must be set. Now this assumption is eliminated and default values for `HTTP_PORT` and `EXTERNAL_HTTP_PORT` environment variables are set in `docker-compose.yml`.
|
Update. The first commit in this PR is no longer relevant. The config in the initial version of As stated in Readme, |
vgorkavenko
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #202 introduced a bug with port variables substitution in the
docker-compose.ymlfile. Because of this bug clickhouse was not running correctly in a docker container. Now this bug is fixed.