feat: Vaults #874
Draft
feat: Vaults #874
+17,551
−6,059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vault factory
…56k1-4.0.4 build(deps): bump secp256k1 from 4.0.3 to 4.0.4
fix: return value and stuff
Co-authored-by: Logachev Nikita <[email protected]>
feat: add separate step for vaults deployment
# Conflicts: # contracts/0.8.9/oracle/AccountingOracle.sol # contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol # lib/protocol/helpers/accounting.ts # lib/state-file.ts # package.json # scripts/scratch/steps/0090-deploy-non-aragon-contracts.ts # test/0.8.9/oracle/accountingOracle.submitReportExtraData.test.ts # test/0.8.9/sanityChecker/oracleReportSanityChecker.misc.test.ts # test/deploy/accountingOracle.ts # test/integration/protocol-happy-path.integration.ts # test/suite/index.ts # yarn.lock
…estions # Conflicts: # contracts/0.8.25/vaults/StakingVault.sol
folkyatina
reviewed
Dec 23, 2024
| // _getTPE is super wide used | ||
| uint256 externalShares = EXTERNAL_SHARES_POSITION.getStorageUint256(); | ||
| uint256 internalShares = _getTotalShares() - externalShares; | ||
| return externalShares.mul(_internalEther).div(internalShares); |
There was a problem hiding this comment.
precision loss here can add up in getPooledEthForShares() and we get double loss on conversion.
Probably, worth to redesign conversion functions in StETH.sol to use internal ETH instead.
based on second review
…estions # Conflicts: # contracts/0.8.25/vaults/Delegation.sol # test/0.8.25/vaults/delegation/delegation.test.ts
[SI] Vaults UX suggestions
…ault [Vaults] Immutably fix the node operator in the basic `StakingVault`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+295
to
+304
| function mintWstETH( | ||
| address _recipient, | ||
| uint256 _tokens | ||
| ) external payable virtual onlyRole(DEFAULT_ADMIN_ROLE) fundAndProceed { | ||
| _mint(address(this), _tokens); | ||
|
|
||
| STETH.approve(address(WSTETH), _tokens); | ||
| uint256 wstETHAmount = WSTETH.wrap(_tokens); | ||
| WSTETH.transfer(_recipient, wstETHAmount); | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
Comment on lines
+169
to
+172
| function valuation() public view returns (uint256) { | ||
| ERC7201Storage storage $ = _getStorage(); | ||
| return uint256(int256(int128($.report.valuation) + $.inOutDelta - $.report.inOutDelta)); | ||
| } |
Check warning
Code scanning / Slither
Potential Arithmetic Overflow Medium
…awn-7.0.6' into feat/dependabot-updates
Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.10.5 to 3.10.11. - [Release notes](https://github.com/aio-libs/aiohttp/releases) - [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst) - [Commits](aio-libs/aiohttp@v3.10.5...v3.10.11) --- updated-dependencies: - dependency-name: aiohttp dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@eslint/plugin-kit](https://github.com/eslint/rewrite) from 0.2.0 to 0.2.4. - [Release notes](https://github.com/eslint/rewrite/releases) - [Changelog](https://github.com/eslint/rewrite/blob/main/release-please-config.json) - [Commits](eslint/rewrite@core-v0.2.0...plugin-kit-v0.2.4) --- updated-dependencies: - dependency-name: "@eslint/plugin-kit" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…into feat/dependabot-updates
…lugin-kit-0.2.4' into feat/dependabot-updates
feat: dependabot updates
TheDZhon
approved these changes
Dec 25, 2024
| contract BeaconChainDepositLogistics { | ||
| uint256 internal constant PUBLIC_KEY_LENGTH = 48; | ||
| uint256 internal constant SIGNATURE_LENGTH = 96; | ||
| uint256 internal constant DEPOSIT_SIZE = 32 ether; |
There was a problem hiding this comment.
Comment on lines
+23
to
+25
| * We cannot use the BeaconChainDepositor contract from the common library because | ||
| * it is using an older Solidity version. We also cannot have a common contract with a version | ||
| * range because that would break the verification of the old contracts using the 0.8.9 version of this contract. |
There was a problem hiding this comment.
wouldn't be relevant once non-32ETH deposits incorporated
Comment on lines
+50
to
+55
| function _makeBeaconChainDeposits32ETH( | ||
| uint256 _keysCount, | ||
| bytes memory _withdrawalCredentials, | ||
| bytes memory _publicKeysBatch, | ||
| bytes memory _signaturesBatch | ||
| ) internal { |
There was a problem hiding this comment.
Suggested change
| function _makeBeaconChainDeposits32ETH( | |
| uint256 _keysCount, | |
| bytes memory _withdrawalCredentials, | |
| bytes memory _publicKeysBatch, | |
| bytes memory _signaturesBatch | |
| ) internal { | |
| function _makeBeaconChainDeposits( | |
| uint256 _keysCount, | |
| bytes memory _withdrawalCredentials, | |
| bytes memory _publicKeysBatch, | |
| bytes memory _signaturesBatch, | |
| uint256[] memory _depositSizes | |
| ) internal { |
There was a problem hiding this comment.
🧠 may check signatures using EIP-2537
Comment on lines
+94
to
+95
| MemUtils.copyBytes(_signature, sigPart1, 0, 0, 64); | ||
| MemUtils.copyBytes(_signature, sigPart2, 64, 0, SIGNATURE_LENGTH - 64); |
There was a problem hiding this comment.
use state-of-the-art assembly MCOPY (https://soliditylang.org/blog/2024/01/26/solidity-0.8.24-release-announcement)
| @@ -0,0 +1,514 @@ | |||
| // SPDX-FileCopyrightText: 2024 Lido <[email protected]> | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2024 Lido <[email protected]> | |
| // SPDX-FileCopyrightText: 2025 Lido <[email protected]> |
Comment on lines
+323
to
+327
| STETH.transfer(address(vaultHub), stETHAmount); | ||
|
|
||
| uint256 sharesAmount = STETH.getSharesByPooledEth(stETHAmount); | ||
|
|
||
| vaultHub.burnSharesBackedByVault(address(stakingVault), sharesAmount); |
| * @param _permit data required for the stETH.permit() method to set the allowance | ||
| */ | ||
| function burnWithPermit( | ||
| uint256 _tokens, |
There was a problem hiding this comment.
Suggested change
| uint256 _tokens, | |
| uint256 _amountOfShares, |
|
|
||
| /** | ||
| * @notice Burns stETH tokens from the sender backed by the vault using EIP-2612 Permit. | ||
| * @param _tokens Amount of stETH tokens to burn |
| IERC20Permit(token).permit( | ||
| owner, | ||
| spender, | ||
| permitInput.value, |
There was a problem hiding this comment.
Comment on lines
+397
to
+401
| STETH.transfer(address(vaultHub), stETHAmount); | ||
|
|
||
| uint256 sharesAmount = STETH.getSharesByPooledEth(stETHAmount); | ||
|
|
||
| vaultHub.burnSharesBackedByVault(address(stakingVault), sharesAmount); |
# Conflicts: # .github/workflows/tests-integration-mainnet.yml # package.json # yarn.lock
feat: vaults Devnet 2 – Holesky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ 🚧 Under construction 🚧 ❗
Staking Vaults
New way of isolated staking, through separate vaults, with optional stETH liquidity