Fix Online Facility Location

[axmmisaka]

Action item

• Verify that this modification is correct and fits the original intention when Prof. Dr. @hokeun wrote it

Problem

Sorry for my delayed reply.

In the original code, in Quadrant's second mutation, toAccumulator (an OutPort) was the destination of two components:
toNextAccumulator of Accumulator:

reactor-ts/src/benchmark/FacilityLocation.ts

Lines 625 to 629 in b81e1ce

	const toAccumulatorOfQuadrant = (
	toAccumulator as unknown as WritablePort<Msg>
	).getPort();
	// Connect Accumulator's output to Quadrant's output.
	this.connect(accumulator.toNextAccumulator, toAccumulatorOfQuadrant);

and the mutation ([M1] itself:

reactor-ts/src/benchmark/FacilityLocation.ts

Lines 757 to 763 in b81e1ce

	toAccumulator.set(
	new ConfirmExitMsg(
	0, // facilities
	supportCustomers.get().length, // supportCustomers
	1 // quadrantReactors
	)
	);

I suppose, effectively, the first connection (which doesn't make much sense in the first place as it was connecting an OutPort to an OutPort), is to make a logic that "once toNextAccumulator is set, we also set toAccumulator"

My current ugly fix is simply replicate this logic without making any additional connection by accessing a parent port from children: in Accumulator:

reactor-ts/src/benchmark/FacilityLocation.ts

Lines 300 to 313 in 82d6e34

	[
	this.fromFirstQuadrant,
	this.fromSecondQuadrant,
	this.fromThirdQuadrant,
	this.fromFourthQuadrant
	],
	[
	this.fromFirstQuadrant,
	this.fromSecondQuadrant,
	this.fromThirdQuadrant,
	this.fromFourthQuadrant,
	this.writable(this.toNextAccumulator),
	parent.writable(parent.toAccumulator),
	],

Then set both ports when one needs to be updated:

reactor-ts/src/benchmark/FacilityLocation.ts

Lines 359 to 374 in 82d6e34

	toNextAccumulator.set(
	new ConfirmExitMsg(
	numFacilities + 1, // Add one for the facility itself.
	// (A quadrant with four children is considered as one facility in Akka-version implementation.)
	numCustomers,
	numQuadrantReactors + 1 // Add one for the quadrant reactor itself.
	)
	);
	parentToAccumulator.set(
	new ConfirmExitMsg(
	numFacilities + 1, // Add one for the facility itself.
	// (A quadrant with four children is considered as one facility in Akka-version implementation.)
	numCustomers,
	numQuadrantReactors + 1 // Add one for the quadrant reactor itself.
	)
	);

I suppose this is not a good way to do it...... So I'm all ears

Originally posted by @axmmisaka in #223 (comment)

[axmmisaka]

This is fixed in #232, closing