pillar: Adapt pillar to use native cpupinning #4430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update pillar's handling of QEMU guests to take advantage of native CPU pinning options introduced in the newer version of QEMU (8.0.4). This eliminates the need for our custom patches to QEMU for CPU pinning. The following changes are included: Removing custom qemu cpu-pinning patches to include the native qemu-pinning feature (1) Refactoring CPU pinning to use integer slices instead of comma-separated strings (2) Updating QEMU command-line arguments to include native CPU pinning options (3) Ensuring compatibility with both KVM and Xen hypervisors (4) This change allows us to leverage upstream QEMU improvements and simplifies the codebase by removing custom patches and complex string manipulations. Tested with QEMU version 8.0.4 Co-authored-by: Roja Eswaran <[email protected]> Signed-off-by: Roja Eswaran <[email protected]>
roja-zededa
requested review from
OhmSpectator,
rene,
rouming,
deitch,
milan-zededa and
eriknordmark
as code owners
github-actions
bot
requested review from
jsfakian,
rucoder,
shjala and
uncleDecart
|
Haven't we already merged it?.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pillar's handling of QEMU guests to take advantage of native CPU pinning options introduced in the newer version of QEMU (8.0.4). This eliminates the need for our custom patches to QEMU for CPU pinning. The following changes are included: Removing custom qemu cpu-pinning patches to include the native qemu-pinning feature (1) Refactoring CPU pinning to use integer slices instead of comma-separated strings (2) Updating QEMU command-line arguments to include native CPU pinning options (3) Ensuring compatibility with both KVM and Xen hypervisors (4)
This change allows us to leverage upstream QEMU improvements and simplifies the codebase by removing custom patches and complex string manipulations. Tested with QEMU version 8.0.4