Node Drain Request/Status API #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewd-zededa , you have some Yetus errors to fix. |
andrewd-zededa
force-pushed
the
kubeapi-drain-api
branch
3 times, most recently
from
0517587
to
f8ffca4
Compare
andrewd-zededa
force-pushed
the
kubeapi-drain-api
branch
3 times, most recently
from
1bb11b3
to
8b25b80
Compare
|
Forgot to actually commit the kube-status change in nodedrain.go, its there now. |
andrewd-zededa
force-pushed
the
kubeapi-drain-api
branch
from
8b25b80
to
8f7e34b
Compare
andrewd-zededa
force-pushed
the
kubeapi-drain-api
branch
from
8f7e34b
to
9bf334e
Compare
The base of an upcoming PR to enable deferring node reboot and shutdown operations. In an Edge-Node-Cluster each node can hold a replica copy of a cluster volume. If the other nodes 1 and 2 in a cluster have recently recovered from a failure they could be rebuilding their replicas (1.x, 1.y, 2.x, 2.y) off of the only remaining readable copies (3.x, 3.y) on node 3. This API is to enable zedagent,nodeagent,baseosmgr to request a drain of replicas off of an edge-node (rebuild completion) before allowing a node outage. Signed-off-by: Andrew Durbin <[email protected]>
andrewd-zededa
force-pushed
the
kubeapi-drain-api
branch
from
9bf334e
to
ca2b216
Compare
|
@eriknordmark changes pushed up to address review questions. Please let me know if any further changes are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base of an upcoming PR to enable deferring node reboot and shutdown operations. In an Edge-Node-Cluster each node can hold a replica copy of a cluster volume. If the other nodes 1 and 2 in a cluster have recently recovered from a failure they could be rebuilding their replicas (1.x, 1.y, 2.x, 2.y) off of the only remaining readable copies (3.x, 3.y) on node 3.
This API is to enable zedagent,nodeagent,baseosmgr to request a drain of replicas off of an edge-node (rebuild completion) before allowing a node outage.