[13.4-stable] Enhance memory-monitor with improved logging, cleanup, and task handling #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the process of extracting PIDs from a cgroup. Instead of using a temporary file and filtering tasks to find unique PIDs based on TIDs, the script now directly reads the `cgroup.procs` file to retrieve the PIDs. This approach reduces complexity, removes the need for intermediate processing, and improves the efficiency of PID retrieval. The redundant temporary task list creation has been removed to streamline the code. Signed-off-by: Nikolay Martyanov <[email protected]> (cherry picked from commit 0a6aedf)
This update moves the file cleanup process to an exit handler to ensure it runs even if the script encounters an error. By trapping the cleanup function, the script reliably archives old files, deletes temporary files, and maintains the total archive size below 100 MB. This change addresses a previous issue where errors could lead to leftover files not being removed, enhancing the overall reliability and resource management. Signed-off-by: Nikolay Martyanov <[email protected]> (cherry picked from commit e71af37)
Add functionality to capture and log the last 10 lines of the handler script output when it exits with a non-zero status. This ensures that relevant log information is sent to syslog, making it accessible to log aggregation tools for better visibility. * Introduced `get_tail()` to extract the last n lines of a log file. * Updated the script handler logic to send the last 10 lines to syslog upon failure. This enhancement improves error diagnosis by ensuring failed handler output is readily available in centralized logging systems. Signed-off-by: Nikolay Martyanov <[email protected]> (cherry picked from commit d65d6a0)
OhmSpectator
deleted the
backport/13.4/improve-memory-monitor-clean-ups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a backport of #4357