Add hv:kubevirt platform:generic arch:amd64 to builds.

[andrewd-zededa]

Multus, cdi, longhorn support arm64 but k8s kubevirt does not have release builds yet.

Just start building for now to help minimize regressions, publishing will start later when the bulk of PRs get merged.

[OhmSpectator]

@andrewd-zededa, argh, our workflows skip the build step if the changes touch workflow only. You can try introducing a minor change in some code to trigger the build. Will it work, @yash-zededa?

[andrewd-zededa]

ah ok, @OhmSpectator I appreciate the help.

[andrewd-zededa]

After a few experiments I switched to this commit which removed all other hv types in the action matrix except kubevirt and it still runs the kvm and Xen builds. The actions must run the copy in master I think, unless i've missed something.

I'll switch over to a commit which I think should work, rename the PR and then we can review.

[andrewd-zededa]

@OhmSpectator I switched back to what I think would add a kubevirt amd64 generic build (if merged).

[eriknordmark]

If you want to publish the images for releases you also need to update .github/workflows/publish.yml
There are others such as buildondemand.yml and assets.yml

[uncleDecart]

You can try introducing a minor change in some code to trigger the build. Will it work, @yash-zededa?

Yes, this will work @OhmSpectator

If you want to publish the images for releases you also need to update .github/workflows/publish.yml
There are others such as buildondemand.yml and assets.yml

If you're not publishing you're just checking that specific configuration is built

[yash-zededa]

You can try introducing a minor change in some code to trigger the build. Will it work, @yash-zededa?

Yes, this will work @OhmSpectator

If you want to publish the images for releases you also need to update .github/workflows/publish.yml
There are others such as buildondemand.yml and assets.yml

If you're not publishing you're just checking that specific configuration is built

I don't think it will work, but we can give it a try.

The publish.yml file is configured to trigger only for branches, not pull requests. GitHub Actions would require the changes to already be in the branch before it can apply the new configuration.

[andrewd-zededa]

If you want to publish the images for releases you also need to update .github/workflows/publish.yml There are others such as buildondemand.yml and assets.yml

@eriknordmark I wasn't sure if we were ready to start publishing the builds, many PRs coming and could introduce odd upgrade issues.

[OhmSpectator]

So, are we okay with merging the current version to test the build without publishing the results currently?

[andrewd-zededa]

@OhmSpectator @uncleDecart @eriknordmark I cleaned up the PR title and description to ready for merging.

[OhmSpectator]

@OhmSpectator @uncleDecart @eriknordmark I cleaned up the PR title and description to ready for merging.

ok, let's test it!

[andrewd-zededa]

Thanks @OhmSpectator I see kubevirt in the current list of PR build for #4304, looks good I think.

[milan-zededa]

Thanks @OhmSpectator I see kubevirt in the current list of PR build for #4304, looks good I think.

One thing though is that pillar for HV=kubevirt (pkg/pillar-kube) is not built inside packages workflow, but rather it is done in the eve workflow right now:
https://github.com/lf-edge/eve/actions/runs/11390610907/job/31692818110?pr=4304#step:10:1070

This is OK for now, but if we add kubevirt build for arm64, the same pillar package will be built twice.

[deitch]

Wasn't that eventually supposed to merge into just one pkg/pillar?