pkg/pillar: reduce test memory usage #4326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
europaul
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
LGTM, but also @OhmSpectator was trying to emulate memory pressure, so maybe high memory usage is very much in the sense of the test 😄
christoph-zededa
changed the title
apparently rand.Seed needs a bit of memory, so better not to call it all the time Signed-off-by: Christoph Ostarek <[email protected]>
christoph-zededa
force-pushed
the
agentlog_test_reduce_mem
branch
from
4025b39
to
c9ee67d
Compare
OhmSpectator
approved these changes
Oct 8, 2024
rene
approved these changes
Oct 8, 2024
rene
reviewed
Oct 9, 2024
| seed := time.Now().UnixNano() | ||
| r := rand.New(rand.NewSource(seed)) | ||
| return r.Float64() * 100 | ||
| return rand.Float64() * 100 |
There was a problem hiding this comment.
@christoph-zededa , out of curiosity, which seed rand will use in this case? It is going to use always the same seed or there is an initialization somewhere?
There was a problem hiding this comment.
I think it is this one here: https://github.com/golang/go/blob/master/src/runtime/rand.go#L61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently rand.Seed needs a bit of memory, so better not to call it all the time
Before:
After:
