Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0-stable] Use eden from the branch EVE-11.0-stable #4317

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

milan-zededa
Copy link
Contributor

@milan-zededa milan-zededa commented Oct 2, 2024

The Eden branch EVE-11.0-stable is based on the latest Eden version 0.9.12 but reverts a commit that includes a test targeting a feature not yet supported in EVE 11.0.

We aim to use the latest version of Eden minus unsupported tests because Eden 0.9.3-stable is not truly stable. Most of its test suites are failing, rendering them largely ineffective.

The Eden branch "EVE-11.0-stable" is based on the latest Eden version
0.9.12 but reverts a commit that includes a test targeting a feature
not yet supported in EVE 11.0.

We aim to use the latest version of Eden minus unuspported tests because
Eden 0.9.3-stable is not truly stable. Most of its test suites are
failing, rendering them largely ineffective.

Signed-off-by: Milan Lenco <[email protected]>
Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@OhmSpectator OhmSpectator merged commit 1620904 into lf-edge:11.0-stable Oct 2, 2024
13 of 14 checks passed
@uncleDecart
Copy link
Member

but the tests didn't run

@uncleDecart
Copy link
Member

Same on master, they're skipped because of run-id, maybe we missed some patches, will look into it later today

@OhmSpectator
Copy link
Member

@uncleDecart, do you mean in this PR? But should they? We merged it earlier than it could trigger any tests, and the build step is not even finished.
For evaluation, I would look at this PR #4312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants