This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Fix validation of IPN response #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $container->setParameter('lexik_paybox.pbx_retour', $param_signed); | ||
| } | ||
| }else{ | ||
| $container->setParameter('lexik_paybox.pbx_retour', null); |
There was a problem hiding this comment.
Maybe you should set the parameter with an empty array or you will get a warning when in_array() is called in Response on line 130:
if (in_array($key, $this->pbxRetour)) {
|
@cedric-g i had forgotten to filter the data in I think this PR can be merge now. |
Conflicts: Paybox/System/Base/Response.php README.md Resources/config/services.yml Tests/Paybox/System/ResponseTest.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the validation process to match specifications about the use of PBX_REPONDRE_A option or the use of the URL specified in paybox interface.
In concrete, if you use the PBX_REPONDRE_A option, the signature must be validated with data returned according to PBX_RETOUR option. While if you define the URL for IPN by the interface of Paybox, the signature must be validated with all the parameters, even those that can be external to PBX_RETOUR (for example a page parameter).