Simplify TestTraces to reduce specificity #7785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c9159be23b910a6674487a45a8a52942aa7245ae)
beautifulentropy
previously approved these changes
Nov 4, 2024
|
While I think this is fine as-is, ideally I'd love some way to know that it's creating Redis spans at all. I think we should leave that for another time though. |
jsha
previously approved these changes
Nov 4, 2024
|
Happy to leave a single redisSpan("get") under new-acct, since I have to resolve merge conflicts anyway. |
aarongable
dismissed stale reviews from jsha and beautifulentropy
via
0f442f5
beautifulentropy
approved these changes
Nov 4, 2024
|
Test-only, merging on one review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestTraces is designed to test whether our Open Telemetry tracing system is working: that spans are being output, that they have the appropriate parents, etc. It should not be testing whether Boulder took a specific path through its code -- that's the domain of package-specific unit tests. Simplify TestTraces to the point that it is asserting (nearly) the bare minimum about the set of operations Boulder performs.