Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state): separate read-only sqlite instance for better concurrency #281

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 2, 2025

@gyuho gyuho self-assigned this Jan 2, 2025
@gyuho gyuho force-pushed the sqlite-read-only-instance branch from 8047cbd to ab6373b Compare January 3, 2025 04:06
@gyuho gyuho changed the title feat(*): separate read-only sqlite instance for better concurrency feat(state): separate read-only sqlite instance for better concurrency Jan 3, 2025
@gyuho gyuho force-pushed the sqlite-read-only-instance branch 4 times, most recently from 904a051 to 7ce38ed Compare January 7, 2025 12:26
@gyuho gyuho force-pushed the sqlite-read-only-instance branch from 1b40741 to ec38861 Compare January 8, 2025 06:18
Copy link
Collaborator

@cardyok cardyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, for GetUID, we can use dbRO only, prob need a new state.GetMachineID func and return err on not found

@gyuho gyuho merged commit cdebb0a into main Jan 8, 2025
5 checks passed
@gyuho gyuho deleted the sqlite-read-only-instance branch January 8, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants