Re-save test.sb3 from current Scratch editor, update snapshot #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note re: snapshot changes in #145, we didn't pretty-print the JSON for test.sb3 this time. It's just a straight export from the Scratch editor. Since future changes should not require any manual JSON finagling, it doesn't save a step for diff convenience anymore, really. |
PullJosh
approved these changes
Jul 9, 2024
The only in-project edit we made was to manually show the list, because the old format appears to not make the monitor visible, mismatching the snapshot.
Matches pre-PR behavior more closely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only in-project edits we made were to 1) manually show the list, because the old format appears to not make the monitor visible, mismatching the snapshot, and to 2) add an "inert" custom block which just runs "stop all", and put that at the top of every script, because otherwise doing practically anything, including opening the project, would mutate the project. (Most specifically, by hiding the list in response to an effective "when timer > 0" block.)
This doesn't implement new tests or make other changes to testing — it just brings the sb3 up to date with current Scratch standards, so it can be re-saved without grievances from the snapshot test. (We did this and ran
npm run testagain just to make sure, but when reviewing, you should, too!)